[PATCH] D16909: Add AMDGPU related triple vendors/OSes

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 12:08:20 PST 2016


tstellarAMD added inline comments.

================
Comment at: lib/Support/Triple.cpp:451
@@ -444,1 +450,3 @@
+    .StartsWith("clover", Triple::Clover)
+    .StartsWith("radeonsi", Triple::RadeonSI)
     .Default(Triple::UnknownOS);
----------------
I'm not sure about this one.  It only really makes sense to use this with the amdgcn target.  It seems like maybe this should be something more generic (mesa?).  


http://reviews.llvm.org/D16909





More information about the llvm-commits mailing list