[PATCH] D16924: [ELF] - Linker script expressions, ASSERT() command.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 11:25:35 PST 2016

grimar added a comment.

In http://reviews.llvm.org/D16924#345138, @ruiu wrote:

> Hi George,
> This is probably too much at this moment. I'm not sure if we want to support ASSERT, but even if we want it, it is something we could add as a final step to complete the linker script support (until that point, we will have everything, so adding ASSERT would be very easy.) The expressions in ASSERT is the features users would use in other contexts. Because that is not plugged in to anywhere in your patch, your patch doesn't demonstrate that that would work for a minimal use case.
> If you want to start working on the linker script support, can you start from writing a proposal about the overall design? It needs to be simple, easy to implement, and fast. I have a few ideas for that, but I don't have enough time to think deeply about them. Feel free to discuss your idea with me.

I didn`t want to support ASSERT, just had no idea how to check correctly that evaluations works and ASSERT was just simple solution to implement in context of this patch for validation purposes. I hoped to use the expressions in futher calculations, for example for location counter support. Thats why it is not plugged to anywhere else.
Probably you're right that overall design is the first step.


More information about the llvm-commits mailing list