[PATCH] D16880: [ELF] - Remove R_X86_64_GOTTPOFF from static relocation proccessing

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 10:19:07 PST 2016

ruiu added inline comments.

Comment at: ELF/Target.h:29
@@ -28,3 +28,3 @@
   virtual bool isTlsDynRel(unsigned Type, const SymbolBody &S) const;
-  virtual unsigned getTlsGotRel(unsigned Type = -1) const { return TlsGotRel; }
+  virtual unsigned getTlsGotRel(unsigned Type) const { return TlsGotDynRel; }
   virtual void writeGotHeader(uint8_t *Buf) const {}
The other dynamic relocation for GOT is "GotRel", so we don't need to add "Dyn", no?

Also, since this is now just an accessor that does nothing, please remove this function and use the field directly.


More information about the llvm-commits mailing list