[PATCH] D16925: [mips] Support LA expansion in PIC mode

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 07:45:26 PST 2016

dsanders requested changes to this revision.
dsanders added a comment.
This revision now requires changes to proceed.

The code change looks right to me but I have some comments about the test case.

Rather than make a new test file, could you extend test/MC/Mips/macro-la.s? This is mostly to keep our test directories tidy but it will also allow us to test that the other cases (e.g. 'la $5, 1') are unaffected and we'll have better coverage of the variety of expressions (e.g. 'la $5, symbol+8($6)', 'la $6, symbol+8($6)', and 'la $5, 1f').


More information about the llvm-commits mailing list