[PATCH] D16920: [AMDGPU] Rename $dst operand to $vdst for VOP instructions.

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1092-1095
@@ -1091,2 +1091,6 @@
   dag ret =
+    !if (!eq(NumSrcArgs, 0),
+      // VOP1 without input operands (V_NOP, V_CLREXCP)
+      (ins),
+      /* else */
     !if (!eq(NumSrcArgs, 1),
----------------
This looks like an unrelated change

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1274
@@ -1269,3 +1273,3 @@
   let Ins64 = (ins InputModsNoDefault:$src0_modifiers, Src0RC64:$src0, Src1RC64:$src1);
-  let Asm64 = "$dst, $src0_modifiers, $src1";
+  let Asm64 = "$vdst, $src0_modifiers, $src1";
 }
----------------
This is a scalar output, so it should not be a vdst

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1320
@@ -1315,3 +1319,3 @@
         // 1 dst, 0 src
-        (inst p.DstRC:$dst),
+        (inst p.DstRC:$vdst),
       !if (!eq(p.NumSrcArgs, 1),
----------------
Is this ever used for instructions with scalar outputs?

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1830
@@ -1825,3 +1829,3 @@
 
-  defm _e64 : VOP3_C_m <op, (outs VOPDstS64:$dst), p.Ins64, opName#p.Asm64, pat64,
+  defm _e64 : VOP3_C_m <op, (outs VOPDstS64:$vdst), p.Ins64, opName#p.Asm64, pat64,
                         opName, p.HasModifiers, DefExec, revOp, sched>;
----------------
This is a scalar output, so it should not be a vdst

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1841
@@ -1836,3 +1840,3 @@
 
-  defm _e64 : VOP3_C_m <op, (outs VOPDstS64:$dst), p.Ins64, opName#p.Asm64, pat64,
+  defm _e64 : VOP3_C_m <op, (outs VOPDstS64:$vdst), p.Ins64, opName#p.Asm64, pat64,
                         opName, p.HasModifiers, DefExec, revOp, sched>,
----------------
Ditto

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1854
@@ -1849,3 +1853,3 @@
   !if(P.HasModifiers,
-      [(set i1:$dst,
+      [(set i1:$vdst,
           (setcc (P.Src0VT (VOP3Mods0 P.Src0VT:$src0, i32:$src0_modifiers,
----------------
Ditto

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1868
@@ -1863,3 +1867,3 @@
   !if(P.HasModifiers,
-      [(set i1:$dst,
+      [(set i1:$vdst,
           (AMDGPUfp_class (P.Src0VT (VOP3Mods0Clamp0OMod P.Src0VT:$src0, i32:$src0_modifiers)), P.Src1VT:$src1))],
----------------
Ditto


http://reviews.llvm.org/D16920