[PATCH] D15949: [mips] Changed the way expressions in instructions are printed to support different kinds of expressions.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 02:09:04 PST 2016

dsanders requested changes to this revision.
dsanders added a comment.
This revision now requires changes to proceed.


As explained at http://reviews.llvm.org/D13592, I'd prefer not to commit this since it further breaks encapsulation of the MCExpr hierarchy. Instead, we should try to get the existing code into our MipsMCExpr. This will be difficult (chiefly because we appear to implement things like %hi as both an operator and part of the symbol which will also need fixing) but fixing the encapsulation will be cleaner overall.


More information about the llvm-commits mailing list