[PATCH] D16864: ELF: Make Out<ELFT> initialization less error-prone.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 14:59:12 PST 2016

ruiu added a comment.

OK to commit?

Comment at: ELF/Writer.cpp:120
@@ +119,3 @@
+  std::unique_ptr<GnuHashTableSection<ELFT>> GnuHashTab;
+  std::unique_ptr<GotPltSection<ELFT>> GotPlt;
rafael wrote:
> Why do these need to be std::uinque_ptr?
Because we want to release the object at end of this function. (Does this answer to your question?)


More information about the llvm-commits mailing list