[PATCH] D16731: Remove unused stackslots generated in reg spills

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 14:54:34 PST 2016

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Wei,

LGTM with a few nitpicks:

1. Add a comment explaining what the test case is testing at the beginning of the file.
2. Change the name of the test case to something relevant, i.e., pr26374.ll is a bad name!


Comment at: lib/CodeGen/InlineSpiller.cpp:990
@@ -989,3 +989,3 @@
-  // Get rid of deleted and empty intervals.
+  // Get rid of unused regs from RegsToSpill.
   unsigned ResultPos = 0;
I liked the previous comments.

Comment at: test/CodeGen/X86/pr26374.ll:1
@@ +1,2 @@
+; PR26374
+; RUN: llc < %s | FileCheck %s
Could you add the description of the related PR, so that we do not have to look at the web page when we want to know what this is about.



More information about the llvm-commits mailing list