[PATCH] D16898: Don't push relocation sections onto InputSection<ELFT>::Discarded.RelocSections

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 13:29:57 PST 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/InputFiles.cpp:217-218
@@ -216,2 +216,4 @@
           Sections[RelocatedSectionIndex];
+      if (RelocatedSection == &InputSection<ELFT>::Discarded)
+        continue;
       if (!RelocatedSection)
----------------
It is better to add a brief comment saying that relocations and relocated sections must be in the same section group, so this is strictly speaking bogus file, but we want to handle that because LLVM 3.3 and earlier creates such file.


http://reviews.llvm.org/D16898





More information about the llvm-commits mailing list