[PATCH] D16881: [ScheduleDAGInstrs] isUnsafeMemoryObject() removed

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 04:35:38 PST 2016

jonpa created this revision.
jonpa added reviewers: atrick, hfinkel.
jonpa added a subscriber: llvm-commits.
Herald added a subscriber: MatzeB.

I think this function is basically useless, since volatile memacesses or MIs with unmodelled sideffects become global memory objects, and the other little checks are also done elsewhere.

It also seems like a good idea to cache the results of getUnderlyingObjectsForInstr(), when it returns no objects. This is a case where we could give up without querying AA for it and initiate a new search for underlying objects. (I am not sure how much of a win this is)



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16881.46895.patch
Type: text/x-patch
Size: 5410 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160204/f7d76de4/attachment.bin>

More information about the llvm-commits mailing list