[llvm] r259675 - Revert r259662, which caused regressions on polly tests.
Tobias Grosser via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 3 21:59:42 PST 2016
On 02/04/2016 12:37 AM, Hal Finkel wrote:
> ----- Original Message -----
>> From: "Wei Mi" <wmi at google.com>
>> To: "Hal Finkel" <hfinkel at anl.gov>
>> Cc: "Tobias Grosser" <tobias at grosser.es>, "llvm-commits" <llvm-commits at lists.llvm.org>
>> Sent: Wednesday, February 3, 2016 5:31:13 PM
>> Subject: Re: [llvm] r259675 - Revert r259662, which caused regressions on polly tests.
>>> 1) test/Isl/CodeGen/non-affine-phi-node-expansion.ll
>>> In this test case LLVM after your patch actually produces more
>>> complicated IR then before. Specifically, it does not inline the
>>> value any more. This is clearly a minor regression which will be
>>> cleaned up by later passes, but it might be of interest to you
> Sounds good. As far as I'm concerned, you can re-commit with the fixes (please make sure the explanations from these e-mails make it into the commit message along with the original text).
Perfect, Wei Mi. This works for me. Please feel free to commit the
necessary Polly test case changes as well.
More information about the llvm-commits