[PATCH] D16831: [regalloc][WinEH] Do not mark intervals as not spillable if they contain a regmask

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 15:55:46 PST 2016

MatzeB added inline comments.

Comment at: include/llvm/CodeGen/LiveInterval.h:550
@@ +549,3 @@
+    // the interval may be required.
+    bool containsRegMask(ArrayRef<SlotIndex> RegMaskSlots) const;
I'd rather call this function something like liveAtIndexes() and also talk about indexes instead of regmasks in the comment. The comments in the header and implementation should just talk about SlotIndexes. The details about regmasks and spilling can be mentioned where this function is used.



More information about the llvm-commits mailing list