[PATCH] D16824: [cfi] Safe handling of unaddressable vtable pointers (compiler-rt).

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 14:05:57 PST 2016

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM with nit

Comment at: test/cfi/target_uninstrumented.cpp:34
@@ +33,3 @@
+  // CHECK: runtime error: control flow integrity check for type 'A' failed during cast to unrelated type
+  // CHECK: invalid vtable in module {{.*}}target_uninstrumented
+  A *a = (A *)p;
Shouldn't you check specifically that the name matches the DSO name? Maybe have your test output to `%T/target-uninstrumented.so` and have this match against that?



More information about the llvm-commits mailing list