[PATCH] D13979: Introduction of FeatureX87

Bruno Cardoso Lopes via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 3 11:35:46 PST 2016

bruno added inline comments.

Comment at: lib/Target/X86/X86ISelLowering.cpp:527
@@ -525,3 +526,3 @@
-  if (!Subtarget.useSoftFloat() && X86ScalarSSEf64) {
+  if (UseX87 && X86ScalarSSEf64) {
     // f32 and f64 use SSE.
aturetsk wrote:
> I get X87 load and store instructions in x87.ll if I don't check hasX87 here. I think changing that would require significant efforts. Since we don't have a CPU which has -x87 but +sse2, I just left the check here.
This looks odd, do you know why it happens? in which specific target feature combination?

Comment at: test/CodeGen/X86/x87.ll:31
@@ +30,3 @@
+; NOX87: __addtf3
+define void @test(i32 %i, i64 %l, float* %pf, double* %pd, fp128* %pld) nounwind readnone {
Please place the checks above the IR instructions you intend to match. Also put a check-label in the beginning of the function.


More information about the llvm-commits mailing list