[PATCH] D16835: InstCombine: Restrict computeKnownBits() on everyValue to OptLevel > 2

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 20:20:06 PST 2016

majnemer added a subscriber: majnemer.
majnemer added a comment.

In http://reviews.llvm.org/D16835#342512, @llvm-commits wrote:

> Given that I don't have a single file in the whole llvm-testsuite where this transformation kicks in I wouldn't know how to start tuning it, so this patch simply pushes it to -O3 only.

I'd rather us not do the expensive work at all instead of stick it under -O3.  Sticking it behind a flag would mean that it gets tested less often.  It doesn't seem to be pulling it's weight for it's cost...



More information about the llvm-commits mailing list