[Diffusion] rL259498: Refactor backend diagnostics for unsupported features

NAKAMURA Takumi via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 16:56:59 PST 2016

chapuni added subscribers: llvm-commits, chapuni.
chapuni added a comment.

Tweaked in r259612.

We should not use neither Twine nor Twine& in DiagnosticInfo.
Twine is not designed for the purpose.

I think StringRef (not StringRef&) might be suitable there. Or use llvm::SmallString, or use std::string.

/llvm/trunk/lib/Target/AMDGPU/AMDGPUISelLowering.cpp:612 It has an implicit constructor and temporary local object, Twine("unsupported call..."). Don't capture it in the record as Twine&.

  olista01 (Author)


More information about the llvm-commits mailing list