[PATCH] D16693: Make sure all subranges are define during re-materialization of constants in RegCoalescer

Marcello Maggioni via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 14:35:44 PST 2016


kariddi added a comment.

Thanks Mathias :-)


================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:1030
@@ +1029,3 @@
+        SlotIndex DefIndex = CurrIdx.getRegSlot(NewMI->getOperand(0).isEarlyClobber());
+        SR->createDeadDef(DefIndex, LIS->getVNInfoAllocator());
+      }
----------------
MatzeB wrote:
> This is a 2nd createDeadDef here, you only need one (at DefIndex)!
Ouch, copy pasting


Repository:
  rL LLVM

http://reviews.llvm.org/D16693





More information about the llvm-commits mailing list