[PATCH] D15642: [asan] Use private aliases for global variables (LLVM part).
Alexey Samsonov via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 2 14:23:56 PST 2016
samsonov added inline comments.
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:104
@@ -103,2 +103,3 @@
static const char *const kAsanGenPrefix = "__asan_gen_";
+static const char *const kODRGenPrefix = "__odr_gen_";
static const char *const kSanCovGenPrefix = "__sancov_gen_";
> samsonov wrote:
> > Consider naming this to __asan_odr_gen, so that we could know that these new globals are smth. added by ASan.
> I'd like to, but I hit on this in Firefox: ASan explicitly exports all **__asan_*** symbols and if we compile our code with e.g -fvisibility=hidden, we can have false positive ODR violation errors.
Oh, I see... `__odr_asan_gen_` ? :)
More information about the llvm-commits