[lld] r259474 - ELF: Simplify and add comments.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 13:43:56 PST 2016

I guess that I still don't fully understand this piece of code. When we
reach here for what? Can you describe it a little bit more in detail for me?

On Tue, Feb 2, 2016 at 1:07 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com
> wrote:

> > +    // We get here if a program was not compiled as PIC.
> > +    if (canBePreempted(Body, /*NeedsGot=*/false)) {
> I don't think the PIC/non-PIC distinction is correct. A reference to a
> hidden symbol in a shared library cannot be preempted for example.
> Cheers,
> Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160202/1116d21e/attachment.html>

More information about the llvm-commits mailing list