[PATCH] D16817: [ELF][MIPS] Pass InputFile and SymbolBody to the Target::relocateOne method

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 12:12:04 PST 2016


ruiu added a comment.

I'm not sure if this is a good change.  Moving MIPS-specific code inside MipsTargetInfo is generally a good thing, but this adds unused parameters to all archs including non-MIPS ones. So MIPS-specific stuff is leaking to other archs here.

If MIPS is so different than the other archs, how about creating relocateOneMips? Do you think that will simplify the code?


Repository:
  rL LLVM

http://reviews.llvm.org/D16817





More information about the llvm-commits mailing list