[PATCH] D16774: AMDGPU: Whitelist handled intrinsics

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 11:24:36 PST 2016

arsenm closed this revision.
arsenm added a comment.


Comment at: lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:546-551
@@ -522,3 +545,8 @@
     IntrinsicInst *Intr = dyn_cast<IntrinsicInst>(Call);
     if (!Intr) {
+      // FIXME: What is this for? It doesn't make sense to promote arbitrary
+      // function calls. If the call is to a defined function that can also be
+      // promoted, we should be able to do this once that function is also
+      // rewritten.
       std::vector<Type*> ArgTypes;
tstellarAMD wrote:
> I'm not sure why this is here.  If it doesn't make sense, feel free to remove it.
I think we should replace it with a return false and an assert so it comes up again when calls are supported


More information about the llvm-commits mailing list