[PATCH] D16783: [LICM] Store promotion when memory is thread local

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 14:30:04 PST 2016

reames added inline comments.

Comment at: lib/Transforms/Scalar/LICM.cpp:928
@@ +927,3 @@
+  // (so that the memory model requirement doesn't apply.)  We first establish
+  // the former, and then run a capture analysis below to establish the later.
+  bool CanSpeculateLoad = false;
sanjoy wrote:
> Though I think I understand it now, I found the code somewhat
> difficult to follow because of the overlap between
> `GuaranteedToExecute` && `CanSpeculateLoad`.  Is it possible to
> instead track `CanSpeculateLoad` and `CanSpeculateStore`?
This would be a completely reasonable refactoring, but I'd strongly prefer to do that as a separate change.  


More information about the llvm-commits mailing list