[PATCH] D16681: [compiler-rt] add_custom_libcxx should pass LLVM_PATH and a C++ compiler

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 13:15:01 PST 2016

samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM, but please address two comments below.

Comment at: CMakeLists.txt:86
@@ -83,3 +85,3 @@
   set(COMPILER_RT_TEST_COMPILER ${CMAKE_C_COMPILER} CACHE PATH "Compiler to use for testing")
Consider adding COMPILER_RT_TEST_CXX_COMPILER here as well (initializing it from ${CMAKE_CXX_COMPILER}).

Comment at: cmake/Modules/AddCompilerRT.cmake:301
@@ -300,2 +300,3 @@
+               -DLLVM_PATH=${LLVM_SOURCE_DIR}
     LOG_BUILD 1
This should be LLVM_MAIN_SRC_DIR


More information about the llvm-commits mailing list