[PATCH] D16785: [AArch64] AArch64LoadStoreOptimizer: fix bug in pre-inc check iterator

[Chad Rosier via llvm-commits]

mcrosier added inline comments.

================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:957
@@ -956,1 +956,3 @@
     unsigned Reg = MO.getReg();
+    if (!Reg)
+      continue;
----------------
Did you mean to delete lines 954 and 955?  Otherwise, I'm not sure why this check would be necessary.

================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1454
@@ -1453,1 +1453,3 @@
+      break;
+  } while(true);
   return E;
----------------
Space between the while and the (.

Or why not just while (MBBI != B)?


http://reviews.llvm.org/D16785