[PATCH] D16616: Avoid inlining call sites in unreachable-terminated block

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 11:54:42 PST 2016


eraman added a comment.

In http://reviews.llvm.org/D16616#339783, @davidxl wrote:

> I mentioned this in another reply. This scenario is rare so this patch
>  is still good in general. If we want to handle it in the future, this
>  heuristics needs to be moved up and can be followed by other threshold
>  adjusting heuristics -- but that should not be required for this
>  patch.
>
> David


Sounds reasonable. I also don't expect this kind of code to appear in real life, but one can imagine microbenchmarks or toy programs to have this pattern.


http://reviews.llvm.org/D16616





More information about the llvm-commits mailing list