[PATCH] D16665: ELF: Do not treat errors in InputFiles class as fatal errors.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 05:33:23 PST 2016

rafael added inline comments.

Comment at: ELF/InputFiles.cpp:213
@@ -192,3 +212,3 @@
       for (uint32_t SecIndex : getShtGroupEntries(Sec)) {
-        if (SecIndex >= Size)
-          fatal("Invalid section index in group");
+        if (SecIndex >= Size) {
+          error("Invalid section index in group");
It looks like most of this patch is converting uses of fatal that can only be reached with broken files.

I don't see the point of supporting some broken files but not others, and I don't think this will scale to supporting all.


More information about the llvm-commits mailing list