[PATCH] D16726: [Profiling] Speed up unittests by ~5x

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 17:58:40 PST 2016

To clarify, it is not 128 iterations, but creating a symbol table with
128 entries -- which is a reasonable size. Test coverage wise, it is
probably the same as a 3-entry symtab.


On Fri, Jan 29, 2016 at 5:51 PM, David Blaikie <dblaikie at gmail.com> wrote:
> On Fri, Jan 29, 2016 at 5:44 PM, David Li via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> davidxl added a comment.
>> I took the liberty to further reduce the test time down to ~6ms.
> The exact time taken isn't what I'm trying to explain - unit tests (& the
> regression suite generally) are intended for targeted testing. This makes
> failures more actionable and stepping through the test case in a debugger
> easier (as well as keeping iteration time low).
> I'm still not sure what even running this a hundred times is adding to our
> test coverage.
> - David

More information about the llvm-commits mailing list