[PATCH] D16727: [Profiling] Write out sparse indexed profiles

[Xinliang David Li via llvm-commits]

Discard the first part of the comment -- that scenario can not exist.

David

On Fri, Jan 29, 2016 at 1:41 PM, David Li <davidxl at google.com> wrote:
> davidxl added inline comments.
>
> ================
> Comment at: lib/ProfileData/InstrProfWriter.cpp:298
> @@ -281,2 +297,3 @@
>    for (const auto &I : FunctionData)
> -    Symtab.addFuncName(I.getKey());
> +    if (shouldEncodeData(I.getValue()))
> +      Symtab.addFuncName(I.getKey());
> ----------------
> This guard is not right -- the function may be referenced by an indirect call target from another emitted function. In fact since text format is mainly used for debugging, I don't see much point honoring sparse flag here.
>
>
> http://reviews.llvm.org/D16727
>
>
>