[PATCH] D16727: [Profiling] Write out sparse indexed profiles

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 13:19:34 PST 2016

vsk added a comment.

(Sorry - typo earlier, slingn's*.)

Comment at: unittests/ProfileData/CoverageMappingTest.cpp:291
@@ -282,1 +290,3 @@
+TEST_P(MaybeSparseCoverageMappingTest, strip_filename_prefix) {
+  InstrProfRecord Record("file1:func", 0x1234, {0});
davidxl wrote:
> So why just this one change. For instance, the previous test can also be changed with {0, 0} counts to cover both the sparse and non sparse paths.
Changing this one test lets us check that we get coverage information for functions which don't execute in sparse mode. I'll update the test you mentioned so it has records with zero and non-zero count.


More information about the llvm-commits mailing list