[PATCH] D16623: Factor out UnrollAnalyzer to Analysis, and add unit tests for it.

Michael Zolotukhin via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 11:58:27 PST 2016

mzolotukhin marked 2 inline comments as done.
mzolotukhin added a comment.

Hi Sanjoy,

I updated the patch, please take a look. As for not exposing it as `InstVisitor`: my intention to move this functionality out is just to enable unit-testing for it. And unit-testing in this case is much easier, as we can actually pin-point interesting cases (e.g. given just two instructions `A` and `B`, if we know that `A` is simplified to `C`, do we simplify `B`?). However, I'm happy to reconsider this if there are arguments against it.



More information about the llvm-commits mailing list