[PATCH] D16648: ELF: Find invalid relocations as many as possible.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: ELF/Driver.cpp:295
@@ -294,1 +294,3 @@
   Target.reset(createTarget());
+  if (!Target)
+    return;
----------------
Unrelated? Or update the patch description.

================
Comment at: ELF/Target.cpp:263
@@ -262,2 +262,3 @@
     default:
-      fatal("Unsupported MIPS target");
+      error("Unsupported MIPS target");
+      return nullptr;
----------------
Unrelated.

================
Comment at: ELF/Target.cpp:273
@@ -271,2 +272,3 @@
   }
-  fatal("Unknown target machine");
+  error("Unknown target machine");
+  return nullptr;
----------------
unrelated.

================
Comment at: ELF/Writer.cpp:168
@@ -165,2 +167,3 @@
   writeSections();
-  fatal(Buffer->commit());
+  error(Buffer->commit());
+
----------------
unrelated?

================
Comment at: ELF/Writer.cpp:173
@@ -167,1 +172,3 @@
+  if (HasError)
+    sys::fs::remove(Config->OutputFile);
 }
----------------
Is this needed? I thought the library we were using deleted the file if commit was not called or it failed.


http://reviews.llvm.org/D16648