[llvm] r259130 - Reland "[CodeView] Use assembler directives for line tables

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 08:25:05 PST 2016


Thanks, I'll take a look at that.

On Fri, Jan 29, 2016 at 2:09 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> >>This reverts commit r259126 and relands r259117.
> +            (LineData & codeview::LineInfo::EndLineDeltaMask) >>
> +            codeview::LineInfo::EndLineDeltaShift;
> +        bool IsStatement = codeview::LineInfo::StatementFlag;
>          W.printNumber("LineNumberStart", LineNumberStart);
>          W.printNumber("LineNumberEndDelta", LineNumberEndDelta);
>          W.printBoolean("IsStatement", IsStatement);
>
> Hi !
> IsStatement assignment looks like a bug for me. I guess it should be
> bool IsStatement = LineData & codeview::LineInfo::StatementFlag;
>
> George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160129/90c80e02/attachment.html>


More information about the llvm-commits mailing list