[PATCH] D16513: [Unittest] Clean up formatting, NFC

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 22:47:52 PST 2016

lhames added inline comments.

Comment at: unittests/ExecutionEngine/Orc/ObjectTransformLayerTest.cpp:327
@@ +326,3 @@
+  std::vector<llvm::Module *> Modules;
+  CompileLayer.addModuleSet(Modules, &Manager, &Resolver);
dblaikie wrote:
> I think I mentioned this during post-commit review, perhaps.
> It's probably possible to just write "{}" for the first parameter - skipping both the local variable and the inline construction. (though, FWIW, I'd probably take the inline construction over the named variable if those were the choices - but I can see the alternative point of view/wouldn't say it's clear cut either way)
addModuleSet is a template method - there's no way for {}'s type to be deduced. Inline construction seems like an option though.


More information about the llvm-commits mailing list