[PATCH] D16258: [PGO] Profile Summary Index profile writer and reader support

David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 14:37:28 PST 2016

davidxl added inline comments.

Comment at: include/llvm/ProfileData/InstrProf.h:743
@@ +742,3 @@
+  /// Max internal block count of the program (excluding entry blocks).
+  uint64_t MaxInternalBlockCount;
+  /// Total number of instrumented blocks/edges.
eraman wrote:
> This is not very useful. In practice we should expect MaxInternalBlockCount == MaxBlockCount
This field is introduced to match the corresponding field in ProfileSummary -- it is used by the current dumper. I prefer keeping it (just 8 byte space).

Comment at: include/llvm/ProfileData/InstrProfReader.h:345
@@ -344,1 +344,3 @@
+  // Read the profile summary. Return a pointer pointing to one byte pass the
+  // end of the summary data if it exists or the input \c Cur.
eraman wrote:
> Nit: pass -> past
will change.


More information about the llvm-commits mailing list