[PATCH] D16688: [test-suite] A number of cmake configuration fixes for External/SPEC.

[Matthias Braun via llvm-commits]

MatzeB added a comment.

Thanks for working on this, this is looking good. At a first glance the changes look good (some comments below). I'll do a testrun later to see whether it still works on our platform with these changes.


================
Comment at: External/SPEC/CINT2000/176.gcc/CMakeLists.txt:7-9
@@ -6,2 +6,5 @@
 endif()
+if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
+  list(APPEND CFLAGS -std=gnu89)
+endif()
 
----------------
I think we can add that flag unconditionally.

================
Comment at: External/SPEC/CINT2000/252.eon/CMakeLists.txt:8-10
@@ -7,1 +7,5 @@
 list(APPEND LIBS -lm)
+if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
+  list(APPEND CPPFLAGS -Wno-implicit-function-declaration)
+endif()
+
----------------
Why do you need to disable this specific warning? I would assume we get many other warnings which are not disabled as well.
Also you can write it the if like this:
```
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
```

================
Comment at: External/SPEC/CINT2000/253.perlbmk/CMakeLists.txt:47-49
@@ -42,2 +46,5 @@
 endif()
+if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
+  list(APPEND CPPFLAGS -std=gnu89)
+endif()
 
----------------
We can add that flag unconditionally.


http://reviews.llvm.org/D16688