[PATCH] D16440: [ThinLTO] Link in only necessary DICompileUnit operands

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 13:03:39 PST 2016

dblaikie added a comment.

It's a little unclear from your description - are you importing /any/ types as definitions? Or are all imported types being imported as declarations? (I think the latter would be good/correct/minimal/simpler)

Comment at: test/Transforms/FunctionImport/funcimport_debug.ll:18
@@ +17,3 @@
+; Confirm that the enums didn't get pulled in to the imported compile unit
+; as it isn't needed here, but ensuring that retainedTypes immediately follows
It might be clearer to match the retained types list (assuming all the types go in there, which I think they do - at least the ones using mangled names, etc) and then match all  the types referenced from there, then you wouldn't need the CHECK-NOTs which are a bit brittle here anyway (if types are emitted in a different order, the CHECK-NOTs wouldn't catch them - they'd only catch the case where the type is emitted between the two surrounding CHECK'd types)

Just a thought. (& could check that things like vtableHolder, etc, aren't emitted in the declarations you're interested in)


More information about the llvm-commits mailing list