[PATCH] D16643: ELF: Report more than one undefined symbols if exist.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Writer.cpp:425
@@ -423,2 +424,3 @@
       ErrorOr<StringRef> SymNameOrErr = Sym.getName(F->getStringTable());
-      fatal(SymNameOrErr);
+      if (!SymNameOrErr) {
+        error(SymNameOrErr);
----------------
rafael wrote:
> I don't think this is related to this patch. This error is about a broken st_name, not about a user error.
Done.

================
Comment at: ELF/Writer.cpp:897
@@ -892,1 +896,3 @@
 
+  if (HasError)
+    return false;
----------------
rafael wrote:
> Please move this just before addCommonSymbols.
Done.


http://reviews.llvm.org/D16643