[PATCH] D16371: [compiler-rt/profile] Added Hostname to .profdata file

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 10:31:49 PST 2016

vsk added a subscriber: vsk.
vsk requested changes to this revision.
vsk added a reviewer: vsk.
vsk added a comment.
This revision now requires changes to proceed.

Hi Daniel, after taking a closer look I noticed a few problems. First, I don't think we should guard off new features if `_MSC_VER` is defined. Second, can't uname be used directly in place of %h in your lit test?


More information about the llvm-commits mailing list