[PATCH] D16641: ELF: Rename error -> fatal and redefine error as a non-noreturn function.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 09:17:42 PST 2016

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits.

Comment at: ELF/Driver.h:24
@@ -23,3 +23,3 @@
 // Entry point of the ELF linker.
-void link(ArrayRef<const char *> Args);
+bool link(ArrayRef<const char *> Args);
Document the bool (is true error or success?).

Comment at: ELF/Error.h:18
@@ -17,1 +17,3 @@
+extern thread_local bool HasError;
This is our first thread_local.  There is not much point in having it until we make a push to support multiple uses from concurrent threads, so I would leave this out for now.


More information about the llvm-commits mailing list