[PATCH] D16590: Refactor backend diagnostics for unsupported features

Oliver Stannard via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 05:31:00 PST 2016


Sorry about this, I misunderstood what the problem is. I've reverted
it as r259043 and r259045 for now.

I could move DiagnosticInfoUnsupported into llvm/SelectionDAG to which
would resolve the cyclic dependency, but that would add a dependency
from clang/CodeGen to llvm/SelectionDAG, which does not currently
exist. Would this be OK, or is there a better solution?

Thanks,
Oliver

On 28 January 2016 at 13:01, NAKAMURA Takumi via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> chapuni added a subscriber: chapuni.
> chapuni added a comment.
>
> I'd revert it (and others) again within a few hours. Could you resolve cyclic deps?
>
> Please include r259040 in the next commit.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D16590
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list