[PATCH] D16110: [Power9] Implement new vsx instructions: quad-precision move, fp-arithmetic

Chuang-Yu Cheng via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 22:06:02 PST 2016

cycheng added inline comments.

Comment at: lib/Target/PowerPC/PPC.td:129
@@ -127,1 +128,3 @@
+                                        "Enable POWER9 instructions",
+                                        [FeatureP8Crypto, FeatureP8Vector]>;
 def FeatureDirectMove :
kbarton wrote:
> Why are we creating a P9 feature?
> For other processors we have defined a processor model, which is a composition of other features (see P7Model and P8Model). 
> We need to think very carefully about how we want these models to be composed, and what can be enabled/disabled as a result of that composition (and whether that is useful). I'm not immediately convinced this is the best way to handle it.  
Sorry I updated late. I've corrected it after our meeting, but I didn't upload it immediately.


More information about the llvm-commits mailing list