[PATCH] D16614: Use "long long int" when checking whether atomics are supported.

Joerg Sonnenberger via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 16:35:02 PST 2016


On Wed, Jan 27, 2016 at 03:23:52PM +0000, Daniel Sanders wrote:
> > Yes, but emulations larging the native register width tend to be
> > significantly slower and raise questions about signal safety and the
> > like. That makes them quite important to avoid for a lot of "production"
> > code.
> 
> It's true that users may want to avoid them for performance reasons but
> this doesn't mean we should fail to compile code that contains emulated atomics.

As I said, I believe that LLVM *should* fail to build when 64bit atomics
are used on 32bit platforms. Nothing in the change indicates that its
impact is limited to the libc++ test suite and.

Joerg


More information about the llvm-commits mailing list