[PATCH] D16468: [ELF] - Attempt to simplify the relocations relaxation code

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 06:37:04 PST 2016

grimar added a comment.

In http://reviews.llvm.org/D16468#336607, @rafael wrote:

> So, I like the general idea of saving info during reloc scan that is
>  then used for reloc application and/or writing dynamic relocations. It
>  is a bit similar to what I did for .dynamic.
> I do have the same concerns as Rui for the current patch. Out of
>  curiosity, have you tried going all the way and just storing *all* the
>  information needed to perform a relocation?
> Cheers,
> Rafael

No, I didn't try to store anything except "Optimized" field yet. To do that it would probably better to perform additional pass/write separate function to get all information in one special place. It sounds as a change to current design and I think at first we should decide do we find the idea to store such amount of additional data acceptable or not.
Personally I would be happy to resurrect this patch and try to do that.


More information about the llvm-commits mailing list