[PATCH] D11393: [X86] Allow X86::COND_NE_OR_P and X86::COND_NP_OR_E to be reversed.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 20:30:03 PST 2016

chandlerc added a subscriber: chandlerc.
chandlerc added a comment.

In http://reviews.llvm.org/D11393#334183, @davidxl wrote:

> LGTM -- watch out for test failures.

David, Gerolf suggested getting one of the x86 maintainers to look at this, and Nadav was CC-ed, but no one with deep knowledge of the x86 backend ever really commented on the patch. =/ Seems somewhat bad form to LGTM without getting one of the long standing maintainers to chime in here.

(And there does appear to be a problem with it, see the comment from James on the commit thread...)



More information about the llvm-commits mailing list