[PATCH] D16616: Avoid inlining CallSites in unreachable-terminated block

[David Li via llvm-commits]

davidxl added a comment.

The patch is straightforward and looks reasonable to me.


================
Comment at: lib/Analysis/InlineCost.cpp:1217
@@ -1216,5 +1216,3 @@
 
-  // If the instruction after the call, or if the normal destination of the
-  // invoke is an unreachable instruction, the function is noreturn. As such,
-  // there is little point in inlining this unless there is literally zero
-  // cost.
+  // If the call site or the normal destination of the invoke is an
+  // unreachable-terminated block, there is little point in inlining this
----------------
If the normal destination of the invoke or the parent block of the call site is unreachable-terminated, ...


http://reviews.llvm.org/D16616