[PATCH] D16599: ELF: Define another entry point.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 17:06:35 PST 2016


ruiu added inline comments.

================
Comment at: ELF/DriverUtils.cpp:143
@@ +142,3 @@
+  // "-lld-no-exec" is the marker that we are in a subprocess.
+  if (Args.size() > 1 && Args[1] == StringRef("-lld-no-exec")) {
+    std::vector<const char *> Argv(Args.begin(), Args.end());
----------------
That is very true. I thought that I knew the risk of not calling exec right after fork, but there were more than I expected. I removed the code for Unix and merged that with Windows code.

================
Comment at: ELF/DriverUtils.cpp:167
@@ +166,2 @@
+  return !Status;
+}
----------------
Fixed.


http://reviews.llvm.org/D16599





More information about the llvm-commits mailing list