[PATCH] D16611: Fix CombineToPreIndexedLoadStore O(n^2) behavior

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 16:58:05 PST 2016

timshen marked an inline comment as done.

Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:6937
@@ -6936,3 +6936,3 @@
 SDNode::hasPredecessorHelper(const SDNode *N,
iteratee wrote:
> Can you add some header comments for hasPredecessorHelper while you're here?
I agree with you in technical perspective, but it's conventional not to make a function parameter passed by const value for reasons I don't quite know :P.

Another solution is to make a local const copy of N and use that, but then it's confusing in another way, since there are more variables.


More information about the llvm-commits mailing list