[PATCH] D16546: [sanitizers] extracted process management functions
Mike Aizatsky via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 26 12:08:47 PST 2016
aizatsky added a comment.
All done. Thanks a lot for review. Running check-all and submitting.
Comment at: lib/sanitizer_common/sanitizer_common.h:290
@@ -282,1 +289,3 @@
+// Checks if specified process is still running
+bool IsProcessRunning(int pid);
> filcab wrote:
> > Should this argument (and StartSubprocess' return value) be something else, since, as Alexey said, "on Windows fd_t is void*"?
> > Probably either a typedef or just a uptr?
> process id is not fd_t. But I agree that uptr might be more appropriate. We use it for ReportFile::fd_pid, for example.
Introduced pid_t typedef.
More information about the llvm-commits