[PATCH] D15687: [Polly] Add conditions for unnecessary value reads

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Michael,

in this patch only the isSynthesisable change seems to actually affect the output, everything else appears to not yet affect anything. 
My feeling is that some of the statements added here will be removed in your later patch at a different location. I would prefer to keep them in the same patch to better see that they are just moved around.

Regarding the isSynthesable change itself. It is touching an area that is a little fishy. Specifically, it will disable (all?) integer read-only memory access modeling as most (all?)l read-only memory accesses are synthesis-able. I need to think about this a little bit to understand if/what that means, to which extend we do this today and how we can correctly model read-only memory accesses then.

Is the isSynthesisable part of this patch blocking subsequent patches?

Best,
Tobias


http://reviews.llvm.org/D15687