[PATCH] D16348: [AVR] Add calling convention parser tokens

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 10:26:20 PST 2016

arsenm added inline comments.

Comment at: test/CodeGen/AVR/calling-conv-interrupts.ll:2
@@ +1,3 @@
+; RUN: llc < %s -march=avr | FileCheck %s
dylanmckay wrote:
> arsenm wrote:
> > Why is this here?
> I added the AVR calling conventions in a previous commit, but forgot to add a test for them. I wrote one here, but marked it `XFAIL` because the target machine cannot be created yet.
> Happy to put it in a separate commit if desired.
These codegen tests should be left for a backend commit where these work.

You should instead replace these with bitcode tests, e.g. see tests/Bitcode/*


More information about the llvm-commits mailing list